[datadog_synthetics_test] Update and standardize example tests #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing uptime test example Standardise example blocks
nkzou
changed the title
nkzou
approved these changes
May 22, 2023
urseberry
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing datadog, I noticed there was no explicit example for an uptime test, which caused me to accidentally configure all uptime tests as
browsertests instead ofapitests.Additionally, I noticed that some of the examples listed things like name, locations, and status towards the top, and others didn't. This caused me to write badly formatted code which I later had to go and correct once I realised what was possible.
This PR exemplifies good quality, readable, standardised code, and also adds a much needed example for uptime tests.