Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_integration_gcp_sts] generate GCP STS account resource #1936

Merged
merged 16 commits into from
May 31, 2023
Merged

[datadog_integration_gcp_sts] generate GCP STS account resource #1936

merged 16 commits into from
May 31, 2023

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented May 26, 2023

No description provided.

@skarimo skarimo requested review from a team as code owners May 26, 2023 19:35
drichards-87
drichards-87 previously approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small bit of feedback from Docs. PR is approved.

docs/resources/integration_gcp_sts_account.md Outdated Show resolved Hide resolved
@joshhuie joshhuie changed the title [datadog_integration_gcp_sts_account] generate GCP STS account resource [datadog_integration_gcp_sts] generate GCP STS account resource May 31, 2023
joshhuie
joshhuie previously approved these changes May 31, 2023
View reviewed changes
drichards-87
drichards-87 previously approved these changes May 31, 2023
View reviewed changes
@skarimo skarimo dismissed stale reviews from drichards-87 and joshhuie via b1eadf9 May 31, 2023 18:11
@skarimo skarimo merged commit 7fd8f83 into master May 31, 2023
8 checks passed
@skarimo skarimo deleted the sherz/generate-gcp-sts-account branch May 31, 2023 18:44
@skarimo skarimo mentioned this pull request May 31, 2023
Closed
skarimo added a commit that referenced this pull request May 31, 2023
@skarimo
Revert "[datadog_integration_gcp_sts] generate GCP STS account resour…
8d00134 
…ce (#1936)"

This reverts commit 7fd8f83.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkzou nkzou nkzou approved these changes

@joshhuie joshhuie joshhuie left review comments

@drichards-87 drichards-87 drichards-87 left review comments

Assignees
No one assigned
Labels
changelog/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skarimo @nkzou @joshhuie @drichards-87