[datadog_synthetics_test] Add plain_proto_file and deprecate compressed_json_descriptor #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlaricCalmette
changed the title
AlaricCalmette
changed the title
HantingZhang2
approved these changes
Feb 8, 2024
Drarig29
approved these changes
Feb 8, 2024
jhgilbert
reviewed
Feb 8, 2024
| @@ -609,8 +609,9 @@ Optional: | |||
| - `no_saving_response_body` (Boolean) Determines whether or not to save the response body. | |||
| - `number_of_packets` (Number) Number of pings to use per test for ICMP tests (`subtype = "icmp"`) between 0 and 10. | |||
| - `persist_cookies` (Boolean) Persist cookies across redirects. | |||
| - `plain_proto_file` (String) The content of a proto file as a string | |||
There was a problem hiding this comment.
Add period at the end of this line for consistency
There was a problem hiding this comment.
I made another pr #2274 for these comment, feel free to give it a 👍
| - `port` (Number) Port to use when performing the test. | ||
| - `proto_json_descriptor` (String) A protobuf JSON descriptor. | ||
| - `proto_json_descriptor` (String, Deprecated) A protobuf JSON descriptor. **Deprecated.** Use `plain_proto_file` instead |
There was a problem hiding this comment.
Add period at the end of this line for consistency
| @@ -954,8 +955,9 @@ Optional: | |||
| - `no_saving_response_body` (Boolean) Determines whether or not to save the response body. | |||
| - `number_of_packets` (Number) Number of pings to use per test for ICMP tests (`subtype = "icmp"`) between 0 and 10. | |||
| - `persist_cookies` (Boolean) Persist cookies across redirects. | |||
| - `plain_proto_file` (String) The content of a proto file as a string | |||
| - `port` (Number) Port to use when performing the test. | ||
| - `proto_json_descriptor` (String) A protobuf JSON descriptor. | ||
| - `proto_json_descriptor` (String, Deprecated) A protobuf JSON descriptor. **Deprecated.** Use `plain_proto_file` instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datadoghq.atlassian.net/browse/SYNTH-13170