Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_logs_index] Fix permadiff on omitted reset time #2280

Merged
merged 1 commit into from
Feb 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions datadog/resource_datadog_logs_index.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ var indexSchema = map[string]*schema.Schema{
Description: "Object containing options to override the default daily limit reset time.",
Type: schema.TypeList,
Optional: true,
Computed: true,
MaxItems: 1,
DiffSuppressFunc: suppressDiffWhenDisabledDailyLimit,
Elem: &schema.Resource{
Expand Down Expand Up @@ -185,8 +186,14 @@ func updateLogsIndexState(d *schema.ResourceData, index *datadogV1.LogsIndex) di
if err := d.Set("daily_limit", index.GetDailyLimit()); err != nil {
return diag.FromErr(err)
}
if err := d.Set("daily_limit_reset", buildTerraformIndexDailyLimitReset(index.GetDailyLimitReset())); err != nil {
return diag.FromErr(err)
if daily_limit_reset, ok := index.GetDailyLimitResetOk(); ok {
if err := d.Set("daily_limit_reset", buildTerraformIndexDailyLimitReset(*daily_limit_reset)); err != nil {
return diag.FromErr(err)
}
} else {
if err := d.Set("daily_limit_reset", nil); err != nil {
return diag.FromErr(err)
}
}
if err := d.Set("daily_limit_warning_threshold_percentage", index.GetDailyLimitWarningThresholdPercentage()); err != nil {
return diag.FromErr(err)
Expand Down