Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codeowners] Add Synthetics CT team #2282

Merged
merged 1 commit into from Feb 15, 2024
Merged

[codeowners] Add Synthetics CT team #2282

merged 1 commit into from Feb 15, 2024

Conversation

Drarig29
Copy link
Contributor

The Synthetics Continuous Testing team will soon take ownership of Terraform for Synthetics.

For now, since the Synthetics App team still has some Jira cards assigned and the knowledge of Terraform for Synthetics, let's co-own the code 馃榿

@Drarig29 Drarig29 requested a review from a team February 14, 2024 14:15
@Drarig29 Drarig29 requested a review from a team as a code owner February 14, 2024 14:15
@Drarig29
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 14, 2024

馃殏 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Feb 14, 2024

鈿狅笍 MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

@Drarig29
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 15, 2024

馃殏 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Feb 15, 2024

鈿狅笍 MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #ci-interfaces!

@nkzou nkzou merged commit b114541 into master Feb 15, 2024
22 of 25 checks passed
@nkzou nkzou deleted the corentin.girard/synthetics-update-codeowners branch February 15, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luissmg luissmg luissmg approved these changes

@HantingZhang2 HantingZhang2 HantingZhang2 approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog mergequeue-status: removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Drarig29 @luissmg @HantingZhang2 @nkzou