[datadog_users] Don't panic if no users is found #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarimo
changed the title
nkzou
previously approved these changes
Feb 29, 2024
skarimo
force-pushed
the
sherz/handle-when-user-not-found
branch
from
f599068
to
3d5202e
Compare
vincentyl
reviewed
Mar 13, 2024
nkzou
approved these changes
Mar 13, 2024
hay-sam
reviewed
Mar 13, 2024
Comment on lines
+204
to
+206
| // We already raised an exception if multiple users were found but no exact email match. | ||
| // If user is nil at this stage, we can assume a user with the same handle already exists. | ||
| // Find the user and raise a helpful error message. |
There was a problem hiding this comment.
i see there is a check for statuscode 409 at the top, why not return the error message for user already exists with handle there?
There was a problem hiding this comment.
At that stage its still recoverable - if the create call 409 conflicts with a disabled user with the same handle and matching email, that user can be re-enabled. Its only an exception if the handle and email of the old user doesn't match, because then we can't resolve which user is being re-enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2292