Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_csm_threats_agent_rules] Add ressource and datasource for CSM Threats agent rule #2316

Merged
merged 24 commits into from Mar 19, 2024

Conversation

Malo10LeGoff
Copy link
Contributor

@Malo10LeGoff Malo10LeGoff commented Mar 13, 2024

Using the updated version of the datadog-api-go-client (created after this PR has been merged), we create CRUD endpoint for CSM Threats agent rules (ex Cloud Workload Security)

Similar endpoints have been defined 2 years ago (see this PR), but now, we define another version, aligning with a backend migration

@Malo10LeGoff Malo10LeGoff changed the title [CWS-1047] - basic structure [datadog_csm_threats_agent_rules] - Add ressource and datasource for CSM Threats agent rule Mar 13, 2024
@Malo10LeGoff Malo10LeGoff marked this pull request as ready for review March 13, 2024 15:29
@Malo10LeGoff Malo10LeGoff requested review from a team as code owners March 13, 2024 15:29
@Malo10LeGoff Malo10LeGoff changed the title [datadog_csm_threats_agent_rules] - Add ressource and datasource for CSM Threats agent rule [datadog_csm_threats_agent_rules] Add ressource and datasource for CSM Threats agent rule Mar 13, 2024
drichards-87
drichards-87 previously approved these changes Mar 13, 2024
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions from Docs and approved the PR.

docs/data-sources/csm_threats_agent_rules.md Outdated Show resolved Hide resolved
docs/resources/csm_threats_agent_rule.md Outdated Show resolved Hide resolved
docs/resources/csm_threats_agent_rule.md Outdated Show resolved Hide resolved
docs/resources/csm_threats_agent_rule.md Outdated Show resolved Hide resolved
docs/resources/csm_threats_agent_rule.md Outdated Show resolved Hide resolved
docs/data-sources/csm_threats_agent_rules.md Show resolved Hide resolved
@nkzou nkzou merged commit 1387446 into master Mar 19, 2024
10 checks passed
@nkzou nkzou deleted the malo.legoff/cws-1047-final branch March 19, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants