-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Webhook Integration #413
Add Webhook Integration #413
Conversation
Fixing issue with buildDatadogHeaders not building the same string consistently. The issue was with Go not guaranteeing order when interating over a map
Added three acceptance tests and fixed issues found while running the tests
Co-Authored-By: Jiri Kuncar <jiri.kuncar@gmail.com>
Hey 👋 the DD web integrations team is working on a new set of API endpoints that will allow manipulating individual webhooks. I'd like to postpone reviewing/merging this PR until after this work is done, so that we could take a similar approach that we took with the pagerduty integration (where we have the top-level pagerduty integration object and then resource for individual pagerduty service objects). Once the new endpoints are ready, I'll get back to this. Either I can advise on how you can do the implementation yourself or I can amend this PR and do it myself if that's ok with you @bkimbrough88. |
Makes sense, I wholly support having a way to manage individual webhooks independent of the main integration. So look forward to seeing those changes. I'll be happy to work with you to amend this PR with those new end points. |
@bkabrda is the new API in place? |
@bkimbrough88 @bkabrda can you share some status, please? |
I check every now and then on https://docs.datadoghq.com/api/latest/webhooks-integration/, API is still V1. I have no idea where this is on DataDog's road map |
@bkabrda @nmuesch @zippolyte Any update on allowing webhook integration/configuration from terraform provider? |
I commented on the issue, closing this one as it doesn't use the right set of APIs. Thanks. |
Adding the webhook integration to the provider as per #344