Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Webhook Integration #413

Closed

Conversation

bkimbrough88
Copy link

Adding the webhook integration to the provider as per #344

Brandon Kimbrough added 2 commits February 17, 2020 09:51
Add Webhook Integration
Add vanilla test cases for integration
Brandon Kimbrough added 2 commits February 17, 2020 17:57
Fixing issue with buildDatadogHeaders not building the same string consistently.
The issue was with Go not guaranteeing order when interating over a map
Added three acceptance tests and fixed issues found while running the tests
@bkimbrough88 bkimbrough88 changed the title WIP: ISSUE-344 Webhook Integration Add Webhook Integration Feb 18, 2020
bkimbrough88 and others added 2 commits February 26, 2020 10:00
Co-Authored-By: Jiri Kuncar <jiri.kuncar@gmail.com>
@bkabrda
Copy link
Contributor

bkabrda commented Mar 9, 2020

Hey 👋 the DD web integrations team is working on a new set of API endpoints that will allow manipulating individual webhooks. I'd like to postpone reviewing/merging this PR until after this work is done, so that we could take a similar approach that we took with the pagerduty integration (where we have the top-level pagerduty integration object and then resource for individual pagerduty service objects).

Once the new endpoints are ready, I'll get back to this. Either I can advise on how you can do the implementation yourself or I can amend this PR and do it myself if that's ok with you @bkimbrough88.

@bkimbrough88
Copy link
Author

Hey the DD web integrations team is working on a new set of API endpoints that will allow manipulating individual webhooks. I'd like to postpone reviewing/merging this PR until after this work is done, so that we could take a similar approach that we took with the pagerduty integration (where we have the top-level pagerduty integration object and then resource for individual pagerduty service objects).

Once the new endpoints are ready, I'll get back to this. Either I can advise on how you can do the implementation yourself or I can amend this PR and do it myself if that's ok with you @bkimbrough88.

Makes sense, I wholly support having a way to manage individual webhooks independent of the main integration. So look forward to seeing those changes.

I'll be happy to work with you to amend this PR with those new end points.

@ghost
Copy link

ghost commented Jan 28, 2021

@bkabrda is the new API in place?

@ghost
Copy link

ghost commented Mar 25, 2021

@bkimbrough88 @bkabrda can you share some status, please?

@bkimbrough88
Copy link
Author

@bkimbrough88 @bkabrda can you share some status, please?

I check every now and then on https://docs.datadoghq.com/api/latest/webhooks-integration/, API is still V1. I have no idea where this is on DataDog's road map

@jake-goodman
Copy link

@bkabrda @nmuesch @zippolyte Any update on allowing webhook integration/configuration from terraform provider?

@therve
Copy link
Contributor

therve commented Aug 19, 2021

I commented on the issue, closing this one as it doesn't use the right set of APIs. Thanks.

@therve therve closed this Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants