Adding support for Protobufs generated with v2 tooling #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneshf-dd
approved these changes
Feb 24, 2023
| "github.com/stretchr/testify/internal/testproto" | ||
| ) | ||
|
|
||
| func TestProtoObjectsAreEqual(t *testing.T) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
testifypackage currently does not support V2 Protobufs and has no plans of adding support.We have a few dozen tests that fail due to this problem once we attempt the upgrade so this fork adds in the needed support to get most of those tests to pass without making a few dozen pull requests.