Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deserialization for union slices #53

Closed
ncpenke opened this issue Jun 28, 2022 · 0 comments · Fixed by #91
Closed

Fix deserialization for union slices #53

ncpenke opened this issue Jun 28, 2022 · 0 comments · Fixed by #91

Comments

@ncpenke
Copy link
Collaborator

ncpenke commented Jun 28, 2022

Currently, this doesn't work because we iterate through a UnionArray manually, and ignore the slice offset. Need to use scalars (#33) to consider the slice offset
This was referenced Jan 13, 2023
Closed
Merged
ncpenke added a commit that referenced this issue Jan 15, 2023
@ncpenke
Follow fix #53: code clean up
82d6973
ncpenke added a commit that referenced this issue Jan 15, 2023
@ncpenke
Follow fix #53: code clean up
bed3616
ncpenke added a commit that referenced this issue Jan 15, 2023
@ncpenke
Follow fix #53: code clean up (#92)
ea44327
ncpenke added a commit that referenced this issue Jan 15, 2023
@ncpenke
Documentation fix #53: Update readme
cc733b6
ncpenke added a commit that referenced this issue Jan 15, 2023
@ncpenke
Documentation fix #53: Update readme
07eeb71
ncpenke added a commit that referenced this issue Jan 15, 2023
@ncpenke
Documentation fix #53: Update readme (#93)
11b5755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly support sliced unions rerun-io/arrow2-convert
1 participant
@ncpenke