Towards #11 Add support for enums #37
Conversation
ncpenke
commented
Apr 2, 2022
ncpenke
commented
- enum slices don't work - need scalar support
| let array_name = &input.common.array_name(); | ||
| let iterator_name = &input.common.iterator_name(); | ||
|
|
||
| // - For dense unions, return the value of the variant that corresponds to the matched arm. Since |
There was a problem hiding this comment.
@jorgecarleitao This is logic going to change once scalar support comes in so that we can serialize slices correctly.
Pretty cool in theory right?! This might be a bit ahead of its time though in terms of downstream uses, since querying nested types doesn't seem to be a thing? But this could be useful for flight rpc or parquet (assuming nested types are already supported or will be supported in the future). Read-only structured data for example JSON docs, can be cleaned and easily stored in parquet. |
|
yeap, very impressive! It reminds me of flatbuffers and the like that can store these type of nested enum variants, but in Arrow and typing in Rust! Amazing idea and implementation, @ncpenke ! Agree that is probably ahead of its time - I do not think arrow2 (or C++ for fwiw) even tests these complex types over IPC lol |
- enum slices don't work - need scalar support
