Enable ssl connections #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi Michael, Thank you for submitting the PR! I am currently in Finland without my laptop. I will review the PR after I get back to work. |
kornilova203
approved these changes
Jan 11, 2019
| @@ -32,7 +32,7 @@ public void testSimpleUri() { | |||
|
|
|||
| @Test | |||
| public void testUriWithUserName() { | |||
| CassandraClientURI uri = new CassandraClientURI("jdbc:cassandra://localhost:9042/?name=cassandra", null); | |||
| CassandraClientURI uri = new CassandraClientURI("jdbc:cassandra://localhost:9042/?user=cassandra", null); | |||
There was a problem hiding this comment.
Thank you for fixing test data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SSL Cassandra clusters this driver is not allowing key store and trust store properties to be used. Please see DataStax SSL Documentation. The cluster builder should be using the withSSL() method if applicable.
This allows you the ability to pass in the JSSE properties as necessary to use SSL.
Tested with Intellij 2018.3 and Datagrip 2018.3