Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove postgres_metadata override in crdb example #231

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Remove postgres_metadata override in crdb example #231

merged 1 commit into from
Oct 17, 2022

Conversation

samredai
Copy link
Contributor

@samredai samredai commented Oct 17, 2022 •
edited
Loading

Summary

Fixes the cockroach db docker setup

Test Plan

Start up the cockroach db docker compose...

docker compose -f docker-compose.yml -f docker-compose.cockroachdb.yml up

...and submitted queries through curl and the graphql UI to confirm that everything works as expected.

Deployment Plan

N/A

@samredai samredai merged commit dba3dd7 into DataJunction:main Oct 17, 2022
youngman-droid pushed a commit to youngman-droid/dj that referenced this pull request Aug 26, 2023
@samredai
Merge pull request DataJunction#231 from samredai/crdb-fix
d3515c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

@agorajek agorajek Awaiting requested review from agorajek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samredai @betodealmeida