Ignore openapi.json when running end-of-file-fixer #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests are failing because the generated openapi spec file doesn't have a new line at the end, which trips up the end-of-file-fixer. I think it's ok to just ignore configure the linter to ignore the file since it's auto-generated.
3 tasks
betodealmeida
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The tests are failing because the generated openapi spec file doesn't have a new line at the end, which trips up the end-of-file-fixer. I think it's ok to just ignore configure the linter to ignore the file since it's auto-generated.
Test Plan
Ran the
make checkandmake testlocally and confirmed that a new line in openapi.json is not picked up by the end-of-file-fixer linter.make checkpassesmake testshows 100% unit test coverageDeployment Plan
N/A