Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new 'uvicorn' group missing from pdm.lock #487

Merged
merged 1 commit into from
May 3, 2023

Conversation

cwegener
Copy link
Contributor

@cwegener cwegener commented May 3, 2023

In commit 4b38435 I of course forgot to refresh the lock file so that it
passes a pdm lock --check.

This commit fixes that, AND it also adds the pre-commit hook to catch
this common mistake.

The command to refresh the lockfile is pdm lock -G :all --refresh

In commit 4b38435 I of course forgot to refresh the lock file so that it
passes a `pdm lock --check`.

This commit fixes that, AND it also adds the pre-commit hook to catch
this common mistake.

The command to refresh the lockfile is `pdm lock -G :all --refresh`
Copy link
Contributor

@shangyian shangyian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@shangyian shangyian merged commit 831e3c6 into DataJunction:main May 3, 2023
7 checks passed
youngman-droid pushed a commit to youngman-droid/dj that referenced this pull request Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants