-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update v20 for Public Exposure #694
Merged
davidtauriello
merged 579 commits into
DataQualityCommittee:v20
from
davidtauriello:v20
Nov 15, 2022
Merged
Update v20 for Public Exposure #694
davidtauriello
merged 579 commits into
DataQualityCommittee:v20
from
davidtauriello:v20
Nov 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove openpyxl to use Arelle requirement, which is pegged at 2.*
Reflects changes provided for Sonny based on negative interest rates being reported by banks.
Reflects changes provided for Sonny based on negative interest rates being reported by banks.
- Updated Tolerance factor for period comparison - Updated Non Neg for DQC Changes - negative interest rates reported by banks - Updated rule 108 to take dimensions into account - Updated rule 131 to have a tolerance for decimal places
- add tests for dqc_0131
- dqc_0084 and dqc_0093
- remove openpyxl to use Arelle requirement, which is pegged at 2.*
- Updated Tolerance factor for period comparison - Updated Non Neg for DQC Changes - negative interest rates reported by banks - Updated rule 108 to take dimensions into account - Updated rule 131 to have a tolerance for decimal places
- add tests for dqc_0131
- dqc_0084 and dqc_0093
Updated functions to fix nested members issue.
Removed as belongs to version 21
* Update functions.xule Updated functions to fix nested members issue. * Updated version number * Updated V19 for member addition fix. * Update .travis.yml for dqc_0118 and dqc_0135 * Updated V19 for rule 118 changes Co-authored-by: Campbell Co-authored-by: marcward
- resources branch update - $status flag from approved rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Seven new rules for US GAAP taxonomy filers are available for public comment from November 15 through December 31, 2022 - see https://xbrl.us/public-review to comment, or use issues and pull requests in this branch.
The first part of the rule determines the presentation children of the abstract concept representing financing items of NetCashProvidedByUsedInFinancingActivitiesAbstract. These concepts are then compared to the concepts not in the financing section of the us-gaap taxonomy defined by the FASB. If there is an intersection then these concepts are output as errors. This misclassification is a problem when trying to determine the financing items from the presentation linkbase.
The second part of the rule determines the presentation children of the abstract concept representing investing items of NetCashProvidedByUsedInInvestingActivitiesAbstract. These concepts are then compared to the concepts not in the investing section of the us-gaap taxonomy defined by the FASB. If there is an intersection then these concepts are output as errors. This misclassification is a problem when trying to determine the financing items from the presentation linkbase.
The third part of the rule identifies those elements defined as presentation descendants of IncreaseDecreaseInOperatingCapitalAbstract in the US-GAAP taxonomy defined by FASB. It then determines if any of these concepts are used in the income statement. In a number of instances filers are taking these elements and using them in the income statement incorrectly.
Pull request process
Once checklist is complete, @campbellpryde @marcward @davidtauriello please review for merge.