Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for v20 Approved (XULE 23379.2) #744

Merged
merged 71 commits into from
May 4, 2023
Merged

Update for v20 Approved (XULE 23379.2) #744

merged 71 commits into from
May 4, 2023

Conversation

davidtauriello
Copy link
Contributor

Changes:

Pull request process

  • Full description of changes provided above.
  • Reviewed by another person. (+1)
  • If this is a code change, reviewed by a second person. (+1)
  • QA'd to the specifications listed here. Documentation only changes do not require the formal code quality assurance process. (+10)
Once checklist is complete, @campbellpryde @marcward @davidtauriello please review for merge.

campbellpryde and others added 30 commits February 17, 2023 13:21
@campbellpryde
Updated rule 145 for Lisa C items
7606cf1 
set(ProceedsFromAdvancesForConstruction, RepaymentsOfAdvancesForConstruction, ProceedsFromContributionInAidOfConstruction)
@campbellpryde
Updated 0145 for lisa C. change
9a15aa7 
Excluded ProceedsFromAdvancesForConstruction, RepaymentsOfAdvancesForConstruction, ProceedsFromContributionInAidOfConstruction as can be investing and financing
@campbellpryde
Updated rule 43 for JPM case
7797581
@campbellpryde
Updated nonnegs
c4b84e0
@campbellpryde
Updated version number
1cfaeb1
@campbellpryde
Updated rules
c00e66e
@davidtauriello
Update for v20.0.2 from CP xule.dqc
0e4ea56
@davidtauriello
Merge branch 'v20' of https://github.com/DataQualityCommittee/dqc_us_…
7a50f30 
…rules into v20
@campbellpryde
Updated rule 91 to exclude InvestmentOwnedPercentOfNetAssets
2de7f0d
@campbellpryde
Update DQC_0091.xule
30eef43
@campbellpryde
Updated rule 140 to improve message
da0fb90
@campbellpryde
Updated rule 90 for tolerance
89846f8
@campbellpryde
Fixed none issue
bece562
@campbellpryde
Delete ael.xml
f8815bb
@campbellpryde
Updated rule 127 to exclude ConsolidatedEntitiesAxis
539638c
@campbellpryde
Test run of V20
fd860a9
@campbellpryde
Updated Rules for V20 using 23280
d6a4617
@campbellpryde
Updated version number
8413bc5
@campbellpryde
Updated V20 rules with correct version number
ac4dd5c 
Add rules not to check calc for parent company member.
@davidtauriello
Update v20
8e7ef8c 
- Add rules not to check calc for parent company member.
- Updated rule 90 for tolerance
- Update rule 91 to exclude InvestmentOwnedPercentOfNetAssets
- Update rule 127 to exclude ConsolidatedEntitiesAxis
@davidtauriello
Update dqc_0140 test case
a665c0b 
- revised messaging
@campbellpryde
Updated constants to adjust Income Items used in the CF
3dce261 
Added ComprehensiveIncomeNetOfTaxIncludingPortionAttributableToNoncontrollingInterest to the list of $income_items
@campbellpryde
Update version.xule
d1d45d7
@campbellpryde
Added ifrs 2023 taxonomy
e7649f2
@campbellpryde
Updated DQC 15 to remove effective tax rec percent items
0040fec
@campbellpryde
Updated rule 139 to line up by dimensions and time.
44aed12
@davidtauriello
Merge branch 'v20' of https://github.com/DataQualityCommittee/dqc_us_…
2fde0a4 
…rules into v20
@campbellpryde
Updated rule 13 to move nonnegs from rule 15
3d70566
@campbellpryde
Updated rule ifrs 130 rule to exclude values equal to 0
e6b3f5b 
Fixed division by zero error.
@campbellpryde
Update DQC_0001.xule
e61b638 
Updated for Long-Duration contracts disclosures expected for Q1, filers are starting to use elements that are located in the ASU 2018-12 Transition section of the US GAAP 2022 taxonomy but are not on the statement of shareholders equity
davidtauriello and others added 28 commits April 19, 2023 14:25
@davidtauriello
Update DQC_0014_ListOfElements.xlsx
905be5b
@campbellpryde
Fixed 140 rule message to eliminate ambiguity of facts.
94ec444 
Updated rule 14 message to address comment rom Chad
@campbellpryde
Updated version Number
34f9697
@campbellpryde
Updated V20 with version 23469
4d6806c 
Version 23469
@campbellpryde
Updated DQC rules version - 23436
b226794 
Block 1 of 3
@campbellpryde
Updated V20.0.5 - On old xule compile version.
4ffb5c2
@campbellpryde
Updated code using new version for V20
ab0f3f2
@davidtauriello
Update dqc_0140 unit tests
99352bd 
message change
@davidtauriello
Merge branch 'v20' of https://github.com/DataQualityCommittee/dqc_us_…
159f551 
…rules into v20
@davidtauriello
Update v20 for Rules Team fixes
04ff8ac
@davidtauriello
Update travis-run.sh
48a7af3 
- rollback to 23379.2
@campbellpryde
Updated rule 142 to include the range axis.
3c489a1
@campbellpryde
Updated rule 118 to exclude the SignificantInvestmentsInAssociatesAxi…
f671bf4 
…s to be consistent with rule 0127
@campbellpryde
Updated rule 15 to exclude DerivativeCostOfHedgeNetOfCashReceived fro…
3502563 
…m the nonneg test.
@campbellpryde
Added constant for disc ops elements
71bec52
@campbellpryde
Updated rule 60 to handle immaterial disc ops
a90d4b0
@campbellpryde
Updated rule message on rule 43
73cf262
@campbellpryde
Update resources.zip
102de51
@campbellpryde
Updated V20
00efeca
@campbellpryde
Updated DQC 60 to handle immaterial amounts
9d1cdb9 
Corrected for negative value using abs.
@campbellpryde
Updated version number to 06
22fa71d
@campbellpryde
Updated V20 this runs on the build 23524
fb3f12a 
This build has been complied with this ruleset. 23524
@campbellpryde
Updated rule 0043 to fix xule error
717f6e5
@campbellpryde
Updated using 23547 this is the same as 23524
8602878
@campbellpryde
Updated to corrected base xule
f8255a9
@campbellpryde
Updated to version 23379
f02c077
@davidtauriello
DataQualityCommittee#743 for XULE 23379
156337f
@davidtauriello
Update .travis.yml and test cases
85b3b8e 
- add dqc_0043.9873 unit tests
@davidtauriello davidtauriello merged commit 6311776 into DataQualityCommittee:v20 May 4, 2023
@davidtauriello davidtauriello mentioned this pull request May 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidtauriello @campbellpryde