Merge for v21.0.4 Approved #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rule submission forms
- reference implementation
- full testing
- filter for modified rule dqc_0140
- dqc_0140 update for tolerance - copyright throughout
- Update for ESEF reference implementation and ruleset .zip files
- Consolidate ESEF into dqc_us_rules - Update for UGT 2023
Added Beat and Foreign tax diff
- run all
* Update DQC_0014_ListOfElements.xlsx * Fixed 140 rule message to eliminate ambiguity of facts. Updated rule 14 message to address comment rom Chad * Updated V21 * Updated rule 142 to include the range axis. * Updated rule 118 to exclude the SignificantInvestmentsInAssociatesAxis to be consistent with rule 0127 * Updated rule 15 to exclude DerivativeCostOfHedgeNetOfCashReceived from the nonneg test. * Added constant for disc ops elements * Updated rule 60 to handle immaterial disc ops * Updated rule message on rule 43 * Updated V21 for V20 changes * Update resources.zip * Updated to include resources * Updated DQC 60 to handle immaterial amounts Corrected for negative value using abs. * Updated rule 0043 to fix xule error * Update dqc-us-2022-V21-ruleset.zip * Update DQC_0150.xule * Update unit tests dqc_0043 * Update DQC.US.0015_testco-2018.xml - remove DerivativeCostOfHedgeNetOfCashReceived * Updated rule 95 to actually handle stock splits * Updated rule 9 to handle stock splits * Updated 108 to improve performance * Updated rule 0144 * Updated rule 150 Updated for business segment changes. Specifically the issue where revenue is split over multiple lines and where there are subsegments. We now identify the leaf segments. * Updated rule 0157 * Updated V21 * Update travis-CI - move --branch to variable - update Arelle to current (2.10.5) * Update DQC_0150.xule Removed invalid attribute type. * Update DQC_0158.xule Updated to check for status extensible enumeration elements for related parties. * Updated rules * Update unit test for sort - dqc_0144 * Update unit tests - update dqc_0009 for stock split - update dqc_0140 unit tests for message change * Update .travis.yml - filter for subset * Updated version number * Update DQC_0158.xule Removed test rule * Updated zip files --------- Co-authored-by: Campbell
Problems with sets when summing sets.
- dqc_0155 and dqc_0158 tests added - increment XULE version
- fix issue with reference implementation code
- dqc_0148.9872 to remove duplicates (XULE set fix)
- add dqc_0157 and dqc_0158
* Updated rule 154 for effective date * Update DQC_0150.xule Removed duplicate effective date and error message. * Update rule submission forms - add dqc_0157 and dqc_0158 * Updated rule 153 to find all monetary siblings * Update DQC_0153.xule * Update effective_dates.csv * Update ifrs_effective_dates.csv * Updated version and resources file for V21 * Update effective_dates.csv * Update resources.zip * Update effective_dates.csv Removed 9372 as is version 22. * Updated V21 with effective dates * Update DQC.US.0153.9879_indb-us-2022.xml - revised for logic and message update * Update for unit testing - run all tests for v21 approved - update to latest Arelle release - remove python-specific NumPy - increment pyparsing * Update v21 rule submission forms for approved --------- Co-authored-by: Campbell
* Update for v21 approved - checkout cp v21 dqc_us_rules - recompiled ruleset.zip to fix dqc_0158 entry 10080 - updated 21,22,23 constant.xule (reference code only) --------- Co-authored-by: Campbell <campbell.pryde@xbrl.us>
* Updated rules for V21 to V21.0.1 --------- Co-authored-by: Campbell
* Update DQC_0158.xule Updated to eliminate long messages * Updated for long message fix. * Update DQC_0158.xule Forgot to remove original value * Updated to fix rule message on 158 Missed removing the original fact. * Set up test case gen for 2022 * Added 2023 generation files * Fixed Resources file for correct SRT elements * Removed V22 files * Fixed V21 to remove V22 stuff for test gen * Updated V21 ruleset zips * Updated V21 for handling non negs for ifrs * Updated version numbers * Updated version numbers * Added rule testing generation * Corrected resource files * Updated testco test files * Update resources.zip Updated resource file for srt us-gaap swap for Broker Dealer Payable element. * Fixed resources issue where did not remove the element below PayablesToBrokerDealersAndClearingOrganizations * Updated fro resource file change * Update test cases for v21.0.2 approved - add dqc_0015 for 2022 and 2023 - update dqc_0158 for message change * Update test cases dqc_0080 and .travis.yml - non-negs for 2022 and 2023 --------- Co-authored-by: Campbell
- split non-negs and dqc_0158 for processing
- checkout from v22
* Updated rule 150 for incomeexpense case shown by NewMarket * Update functions.xule Correct dimension equals to set when should have been in. * Update version.xule * Updated test case generation. * Update constant.xule Update constants to identify concepts in cubes in the notes. * Update .travis.yml - filter for dqc_0015 and dqc_0150 - update dqc_0015 log.xml files for Travis-CI compare - cleared cache and recreated log files * Updated rule 117 to handle related parties * Updated rule 117 for legal entity axis * Update constant.xule Removed excess constants * Fixed rule 150 for nonneg * Update version.xule * Updated V21 * Update unit tests for dqc_0080, dqc_0117 and dqc_0150 * Update .travis.yml - run all for version 21.0.4 --------- Co-authored-by: Campbell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Pull request process
Once checklist is complete, @campbellpryde @marcward @davidtauriello please review for merge.