Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for v23 Approved #805

Merged
merged 28 commits into from Feb 12, 2024
Merged

Update for v23 Approved #805

merged 28 commits into from Feb 12, 2024

Conversation

davidtauriello
Copy link
Contributor

@davidtauriello davidtauriello commented Feb 10, 2024 •
edited

Changes:

  • dqc_0118 take into account the decimals of the components
  • dqc_0162 exclude tickers containing description of Notes; look at the member value
  • dqc_0168 allow an opt out - TaxReconciliationNotRequired
  • dqc_0176 handle us-gaap elements dragged in by ECD; handle F1 report
  • Added US_GAAP constant to ensure 2020 is compatible with other taxonomies
  • Recompile ruleset .zip files (Arelle 2.23.1 XULE 23694.1)
  • Update test cases for message changes dqc_0118 and dqc_0168
  • Update .travis.yml and travis-run.sh for PYTHON_VERSION variable

Pull request process

  • Full description of changes provided above.
  • Reviewed by another person. (+1)
  • If this is a code change, reviewed by a second person. (+1)
  • QA'd to the specifications listed here. Documentation only changes do not require the formal code quality assurance process. (+10)
Once checklist is complete, @campbellpryde @marcward @davidtauriello please review for merge.

campbellpryde and others added 18 commits February 1, 2024 15:55
@campbellpryde
Updated 170 to check year end filings
a651885
@campbellpryde
Updated rule to fix date equal issue in rule 170
04312ce
@campbellpryde
Updated rule 190 to give filers the option to not disclose the reconc…
d63516c 
…iliation.
@campbellpryde
Updated rules for V23.02 changes
1781b0c
@campbellpryde
Updated rule 162 to exclude tickers containing description of Notes
8337b47
@campbellpryde
Updated rule 118 to take into account the decimals of the components.
d130db5
@campbellpryde
Updated rule 162 to look at the member value.
22886a2
@campbellpryde
Updated rule 176 to handle us-gaap elements dragged in by ECD.
d219fd5
@campbellpryde
Added US_GAAP constant to ensure 2020 is compatible with other taxono…
ff6def5 
…mies
@campbellpryde
Updated rule 176 to handle us-gaap elements dragged in by ECD.
fd42b58
@campbellpryde
Update version.xule
44daeee
@campbellpryde
Updated V23 changes
6aa5619
@campbellpryde
Updated rule 0168 to allow an opt out
b39023a 
Can use element TaxReconciliationNotRequired
@campbellpryde
Updated rule 176 to handle the F1 report.
f0b9f14
@davidtauriello
Update from CP xule.dqc
034daab 
- dqc_0162 exclude tickers containing description of Notes
- dqc_0118 take into account the decimals of the components
- dqc_0162 look at the member value
- dqc_0176 handle us-gaap elements dragged in by ECD
- dqc_0168 allow an opt out - TaxReconciliationNotRequired
- dqc_0176 handle F1 report
- Added US_GAAP constant to ensure 2020 is compatible with other taxonomies
@campbellpryde
Updated rule 118 to fix min error.
ff056c5
@davidtauriello
Update from CP xule.dqc
b96e075
@davidtauriello
Recompile ruleset .zip files
0ad638d 
Arelle 2.23.1 XULE 23694.1
@davidtauriello davidtauriello merged commit 7bfc21c into DataQualityCommittee:v23 Feb 12, 2024
@davidtauriello davidtauriello mentioned this pull request Feb 12, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidtauriello @campbellpryde