Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for v23 Approved #807

Merged
merged 46 commits into from Feb 15, 2024
Merged

Update for v23 Approved #807

merged 46 commits into from Feb 15, 2024

Conversation

davidtauriello
Copy link
Contributor

Changes:

  • Update dqc_0154 to include "and" as an exclusion case
  • Update dqc_0013 to remove negatives for gilti
  • Increment version and recompile ruleset .zip files

Pull request process

  • Full description of changes provided above.
  • Reviewed by another person. (+1)
  • If this is a code change, reviewed by a second person. (+1)
  • QA'd to the specifications listed here. Documentation only changes do not require the formal code quality assurance process. (+10)
Once checklist is complete, @campbellpryde @marcward @davidtauriello please review for merge.

davidtauriello and others added 30 commits April 3, 2023 07:05
@davidtauriello
Update dqc_0015 .csv files
39ccabc 
- fix conflict error
@davidtauriello
Merge remote-tracking branch 'upstream'
056273c
@davidtauriello
Merge branch 'master' of https://github.com/DataQualityCommittee/dqc_…
fbf0364 
…us_rules
@davidtauriello
Merge remote-tracking branch 'upstream/master'
26d89ed
@davidtauriello
Update rule submission forms
6ccf002 
- update heading "Authoritative reference" to "Basis for logic"
@davidtauriello
Update from DQC v22.0.3-x
b0557d1
@campbellpryde
Updated 170 to check year end filings
a651885
@campbellpryde
Updated rule to fix date equal issue in rule 170
04312ce
@campbellpryde
Updated rule 190 to give filers the option to not disclose the reconc…
d63516c 
…iliation.
@campbellpryde
Updated rules for V23.02 changes
1781b0c
@davidtauriello
Create dqc_us_rules.yml
4f716e3
@campbellpryde
Updated rule 162 to exclude tickers containing description of Notes
8337b47
@campbellpryde
Updated rule 118 to take into account the decimals of the components.
d130db5
@campbellpryde
Updated rule 162 to look at the member value.
22886a2
@campbellpryde
Updated rule 176 to handle us-gaap elements dragged in by ECD.
d219fd5
@campbellpryde
Added US_GAAP constant to ensure 2020 is compatible with other taxono…
ff6def5 
…mies
@campbellpryde
Updated rule 176 to handle us-gaap elements dragged in by ECD.
fd42b58
@campbellpryde
Update version.xule
44daeee
@campbellpryde
Updated V23 changes
6aa5619
@campbellpryde
Updated rule 0168 to allow an opt out
b39023a 
Can use element TaxReconciliationNotRequired
@campbellpryde
Updated rule 176 to handle the F1 report.
f0b9f14
@davidtauriello
Update from CP xule.dqc
034daab 
- dqc_0162 exclude tickers containing description of Notes
- dqc_0118 take into account the decimals of the components
- dqc_0162 look at the member value
- dqc_0176 handle us-gaap elements dragged in by ECD
- dqc_0168 allow an opt out - TaxReconciliationNotRequired
- dqc_0176 handle F1 report
- Added US_GAAP constant to ensure 2020 is compatible with other taxonomies
@campbellpryde
Updated rule 118 to fix min error.
ff056c5
@davidtauriello
Update from CP xule.dqc
b96e075
@davidtauriello
Recompile ruleset .zip files
0ad638d 
Arelle 2.23.1 XULE 23694.1
@campbellpryde
Updated rule 118 to fix min error.
cc8650d
@campbellpryde
Removed potential case conflict
871c4ef
@davidtauriello
Update .travis.yml and .sh
f89e82d 
- Arelle 2.23.1
- create variable $PYTHON_VERSION
@davidtauriello
Update from CP xule.dqc
22e5159
@campbellpryde
Fixed missing constant in 2020 ruleset
d1322e5
campbellpryde and others added 16 commits February 12, 2024 09:42
@campbellpryde
Updated 166 to be consistent
bad693c
@davidtauriello
Update from CP xule.dqc
f20f69c
@davidtauriello
Recompile ruleset .zip files v23.0.3
1d30fae 
- Arelle 2.23.1 XULE 23694
@davidtauriello
Update .travis.yml
ce804bc 
- fix PYTHON_VERSION variable
@campbellpryde
Updated rule 154 to include "and" as an exclusion case.
81b2689
@davidtauriello
Update test cases for changes dqc_0118 and dqc_0168
2fa4334
@davidtauriello
Update unit tests for v23
25a6aaa
@davidtauriello
Merge for v23.0.3 Approved (DataQualityCommittee#806)
eeb8da6 
* Updated rule 0168 to allow an opt out

Can use element TaxReconciliationNotRequired

* Updated rule 176 to handle the F1 report.

* Updated rule 118 to fix min error.

* Recompile ruleset .zip files

Arelle 2.23.1 XULE 23694.1

* Updated rule 118 to fix min error.

* Removed potential case conflict

* Update .travis.yml and .sh

- Arelle 2.23.1
- create variable $PYTHON_VERSION

* Fixed missing constant in 2020 ruleset

* Updated 166 to be consistent

* Recompile ruleset .zip files v23.0.3

- Arelle 2.23.1 XULE 23694

* Update .travis.yml

- fix PYTHON_VERSION variable

* Update test cases for changes dqc_0118 and dqc_0168

---------

Co-authored-by: campbellpryde
@davidtauriello
Merge remote-tracking branch 'upstream/master'
d95db9d
@davidtauriello
Update from DQC v23.0.3
1fc96cc
@davidtauriello
Update from DQC v23.0.3
2f01d78
@campbellpryde
Updated rule 13 to remove negatives for gilti
c2d0fad
@davidtauriello
Update from CP xule.dqc v23
9d584f3 
- fix copyright
@davidtauriello
Update to fix typo in dqc_0013
99a99af
@davidtauriello
Increment version and recompile ruleset .zip files
6f8f333
@davidtauriello
Update .gitignore
d2c3929 
- exclude github workflows and build commands
@davidtauriello davidtauriello merged commit db8f9cc into DataQualityCommittee:v23 Feb 15, 2024
@davidtauriello davidtauriello mentioned this pull request Feb 15, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidtauriello @campbellpryde