Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge for v23.0.9 Approved #818

Merged
merged 725 commits into from Apr 10, 2024
Merged

Merge for v23.0.9 Approved #818

merged 725 commits into from Apr 10, 2024

Conversation

davidtauriello
Copy link
Contributor

Changes:

Pull request process

  • Full description of changes provided above.
  • Reviewed by another person. (+1)
  • If this is a code change, reviewed by a second person. (+1)
  • QA'd to the specifications listed here. Documentation only changes do not require the formal code quality assurance process. (+10)
Once checklist is complete, @campbellpryde @marcward @davidtauriello please review for merge.

davidtauriello and others added 30 commits November 14, 2023 12:16
- update for v21 approved and v20 removals
- fix typos
- clarify dqc_0045, dqc_0077, dqc_0120
- update for v21 approved and v20 removals
- add v23 for public review
Added rule 177
Added in rule identifier into 177
Added new rule form for 175
* Added new rules for tax reconciliation.

* Update version.xule ESEF

* Update nonneg unit tests dqc_0015 and dqc_0080

* Update .travis.yml

* Update nonneg unit tests dqc_0015 and dqc_0080

* Update .travis.yml

- add dqc_0080 unit tests IFRS 2022 and 2023

* Updated V23

* Update DQC_0171.xule

* Updated functions to handle rule 118 for related parties

* Update dqc-us-2023-V23-ruleset.zip

* Update functions.xule

Updated for related party changes

* Updated functions to handle related parties

* Updated rule 164 to address supplemental information.

* Added ECD taxonomy

* Added ECD to settings

* Updated Rule 120 to remove the calculation linkbase from rule

- updated rule to ignore the calculation linkbase and use the presentation only to determine the balance sheet contains lease info
- Updated the message to include the period

* Updated IFRS Constants for new rules

* Added IFRS 167 to follow us gaap.

* Added IFRS 168

* Added IFRS 169 to mirror US-GAAP taxonomy rule

* Updated constants for new rules.

* Updated rule 166 rule number.

* Added rule 167

Check where calculation has subtotals as leaf nodes in the financial statements

* Added rule 168 to check the Income tax reconciliation

* Added rule 169 to check calcs in the Parenthetical Section.

* Update DQC_0164.xule

Updated to remove excess text

* Fixed typo in rule 171

* Updated IFRS and US GAAP rules

* Updated ESEF Rules

* Updated tasks to include stack info.

* Fixed Function file to be consistent across all taxonomy versions

Removed hardcoded element in function file

* Updated Rule 120 to remove the calculation linkbase from rule

- updated rule to ignore the calculation linkbase and use the presentation only to determine the balance sheet contains lease info
- Updated the message to include the period

* Updated rule 164 to address supplemental information.

* Updated Rule 120 to remove the calculation linkbase from rule

- updated rule to ignore the calculation linkbase and use the presentation only to determine the balance sheet contains lease info
- Updated the message to include the period

* Updated IFRS Constants for new rules

* Updated rule 166 rule number.

* Fixed Function file to be consistent across all taxonomy versions

Removed hardcoded element in function file

* Updated rule 166 to have the correct rule number for IFRS

* Update DQC_IFRS_0166.xule

Fixed rule number.

* Updated rule 139 to exclude consolidated entitiies

In some cases subs are investment vehicles with more capital risk weighted assets. See municipal bank.

* Updated rule 167 to fix xule error.

* Added rule 172

* Added rule 173

* Added rule 174

* Update DQC.code-workspace

* Fixed error in rule 0168

Fixed issue where extension elements were generating errors as they were not in the base taxonomy.

* Updated rule 139 to exclude consolidated entitiies

In some cases subs are investment vehicles with more capital risk weighted assets. See municipal bank.

* Added rule 174

* Updated nonneg items

* Updated rule 166 to fix error

* Updated rule 166 to fix error

* Updated nonneg items

* Update resources.zip

Updated resource zip

* Fixed typo in rule 167

* Fixed typo of reonciliation on rule 168

* Submitted compiled rules

* Fixed typo in rule 172

* Updated comment in rule 173

* Updated rule 174 to fix element error

* Update version.xule

* Updated V23 Ruleset

* Update resources.zip

* Added period and rule number to rule 88

* Updated version number

* Updated version 22 for DQC meeting changes

* Added period and rule number to rule 88

* Updated V20 for possible corruption

* Update dqc-us-2020-V23-ruleset.zip

Added in package

* Recompiled V23 rules

* Updated rule 167 to have an appropriate error message.

* Updated IFRS rule 118 to point to the correct function arguments

* Updated rule prefix for ESEF rules

* Added rule name prefix

* Removed unsupported function.

* Add rule-name prefix

* Fixed rule 173 to get references

* Removed role on rule 172

* Added rule prefix to 169

* Updated IFRS rule 118 to point to the correct function arguments

* Updated V23 rules to fix the xule errors

* Removed extra Rule name prefix in rule 88

* Revert "Removed extra Rule name prefix in rule 88"

This reverts commit ef8c6c2.

* Update v22 rule submission forms

- dqc_0088 restored with second evaluation
- dqc_0164 remove components 4 and 5
- dqc_0174 add for approval

* Added rule 152 per FASB request

* Removed extra rule prefix in rule 88

* Removed extra rule prefix in rule 88

* Fixed message problem in rule 169

* Removed Fidi and gilti nonnegs

* Removed Fidi and gilti nonnegs

* Updated resources.zip

* Updated V23 for new FASB rule.

* Updated V22.

* Updated version number and status for v22

* Updated V22 rules

* Added documentation to Repo

* Added additional rules

* Updated rule 152 for typos

* Add documentation for rule 166

* Create DQC_0152.md

Added rule 152 documentation.

* Update unit tests for v22 changes dqc_0120 and dqc_0139

* Update rule submission forms for v22 approved

* Update for v22 approved (#779)

* Update version.xule ESEF

* Update nonneg unit tests dqc_0015 and dqc_0080

* Update .travis.yml

* Update functions.xule

Updated for related party changes

* Updated Rule 120 to remove the calculation linkbase from rule

- updated rule to ignore the calculation linkbase and use the presentation only to determine the balance sheet contains lease info
- Updated the message to include the period

* Updated rule 164 to address supplemental information.

* Updated Rule 120 to remove the calculation linkbase from rule

- updated rule to ignore the calculation linkbase and use the presentation only to determine the balance sheet contains lease info
- Updated the message to include the period

* Updated IFRS Constants for new rules

* Updated rule 166 rule number.

* Fixed Function file to be consistent across all taxonomy versions

Removed hardcoded element in function file

* Updated rule 139 to exclude consolidated entitiies

In some cases subs are investment vehicles with more capital risk weighted assets. See municipal bank.

* Added rule 174

* Updated rule 166 to fix error

* Updated nonneg items

* Update resources.zip

* Added period and rule number to rule 88

* Updated version number

* Updated version 22 for DQC meeting changes

* Updated IFRS rule 118 to point to the correct function arguments

* Removed extra rule prefix in rule 88

* Removed Fidi and gilti nonnegs

* Updated V22.

* Updated version number and status for v22

* Updated V22 rules

* Update unit tests for v22 changes dqc_0120 and dqc_0139

* Update rule submission forms for v22 approved

---------

Co-authored-by: Campbell

* Update dqc_0015 for 2023 changes

- FinancingReceivableAllowanceForCreditLossesIndividuallyEvaluatedForImpairment1, EffectiveIncomeTaxRateReconciliationFdiiAmount, EffectiveIncomeTaxRateReconciliationGiltiAmount

* Update .travis.yml

* Update unit test dqc_0015 for 2023 changes

- FinancingReceivableAllowanceForCreditLossesIndividuallyEvaluatedForImpairment1, EffectiveIncomeTaxRateReconciliationFdiiAmount, EffectiveIncomeTaxRateReconciliationGiltiAmount

* Fixed IFRS rule 173.

* Update DQC_0150.xule

Updated to be consistent with other years.

* Update DQC_0150.xule

Updated DQC 0150 for non neg

* updated for rule 150

* Merge branch 'v22' of https://github.com/campbellpryde/xule.dqc into v22

* Update dqc_0015 for 2022 unit test

* Updated v23

* Update tasks.json

Add code to run in python version 3.12

* Create dqc_v23_compile.sh

Added build script

* Update rule submission forms for v22 Approved

* Update rule submission forms for public exposure

- Add v23 rules for public exposure - dqc_0167, dqc_0168, dqc_0169, dqc_0170, dqc_0171, dqc_0172, dqc_0173
- Update rule submission form README.md

* Update rule submission forms

- change directory

* Recompile v23.0.0RC1

- djt recompile of reference code

* Updates to rule 115

* Create dqc_0080_ifrs_2023_concepts.csv

* Update dqc_0080_ifrs_2023_concepts.csv

* Update dqc_0080_ifrs_2021_concepts.csv

* Update .travis.yml and rulesetMap.json

- run all

- rulesetMap.json files for v23

* Updated resources files

* Fixed rule 174 to use correct function

* Updated V22

* Update dqc_0080 non-negs

- changes based on DQC Rules Dev Team

* Update unit test IFRS dqc_0080

- non-neg changes

* Update version v22

- v22.0.1

* Compiled ruleset .zip files v22.0.1

* Update unit tests for v22

- update dqc_0080 IFRS 2023 unit test
- add dqc_0174
- update dqc_0164

* Update v22 approved (#781)

* Create dqc_0080_ifrs_2023_concepts.csv

* Update dqc_0080_ifrs_2023_concepts.csv

* Update dqc_0080_ifrs_2021_concepts.csv

* Updated resources files

* Fixed rule 174 to use correct function

* Updated V22

* Update unit test IFRS dqc_0080

- non-neg changes

* Update version v22

- v22.0.1

* Compiled ruleset .zip files v22.0.1

* Update unit tests for v22

- update dqc_0080 IFRS 2023 unit test
- add dqc_0174
- update dqc_0164

---------

Co-authored-by: Campbell

* Update .travis.yml

* Update .travis.yml

* Update unit tests dqc_0164

* Update unit tests dqc_0164

* Update dqc_0080 IFRS 2022 unit test

* Update dqc_0080 IFRS 2022 unit test

* Update .travis.yml

* Update dqc_0080_ifrs_2023_concepts.csv

* Updated resources for V23

* COmplied version23 of the rules

* Fixed error in rule 174

* Updated v22

* Update ruleset .zip

- re-issue v22.0.1

* Update .travis.yml

- run all

* Update test suite from v22

* Update .travis.yml for v23 unit tests

* Update v23 unit tests

-dqc_0167, dqc_0168, dqc_0169

* Updated error message for rule 89 per FASB request.

* Update DQC_0045.md

Updated documentation from children to descendant.

* Updated error message for rule 89 per FASB request.

* Updated rule 167 to give sensible rule messages.

* Updated V23 rules

* Delete dqc-ifrs-2023-V22-ruleset.zip

* Recompile rules and update v23 unit tests dqc_0167

* Update .travis.yml

* Update v23 ruleset .zip files

* Update ESEF README.md

- increment version

* Update ESEF README.md

* Updated rule 167 for role issues

* Update DQC_0077.md

Updated description of rule 77

* Updated rules

* Delete DQC.US.0167.10106_VVPR_IFRS-2023.xml

* Update unit tests for dqc_0167

* Updated the IFRS Taxonomy rule 168 to change message from US GAAP to IFRS

* Update DQC_0120.md

Updated rule description from calculation to presentation.

* Update DQC_0152.xule

Removed invalid description at the top of the rule.

* Updated rule 168 for reconciliation check

* Updated us-gaap for tax rec check

* Added rule 0175

* Added rule 176 Based on FASB comments

* Updated the message for rule 167

* Updated rule 169 to check cashflows supplemental instant values are excluded.

* Updated rule 159 to ignore where there are no cashflows for a Q

* Updated V23

* Update ESEF functions and version XULE files

- fix symlink
- version v23.0.0RC1

* Recompile v23

* Update .travis.yml

- run all except dqc_0167

* Update esef version number

* Updated error message for IFRS 176

* Update DQC_0166.xule

Updated rule to improve performance potentially

* Update DQC_0170.xule

Added rule for 170 based on feed back from Shelly Wavrin.

* Updated rule 167 to fix xule error where the rule adds a set to a string.

* updated for 167 and veersion

* Update directories for IFRS rules

* Recompile rulesets v23

- confirming compile
- ESEF rulesets are not recompiled

* Update v23 test cases

- dqc_0080 changes
- dqc_0159, dqc_0167, dqc_0169

* Update directories for IFRS rules

* Update rule submission forms

- clarify dqc_0045, dqc_0077, dqc_0120

* Removed incorrect description.

* Update DQC_0080_ListOfElements.xlsx

- update for v21 approved and v20 removals

* Updated rule number for 175

* Removed bad text in 152

* Update DQC_0080_ListOfElements.xlsx

- update for v21 approved and v20 removals

* Update DQC_0152.md

- fix typos

* Update v22 rule submission forms and vscode support files

* Recompiled v23

* Added rule 177

* Create http-xbrl-sec-gov-ecd-2022.json

* Added a rule to 170

* Update namespace.xule

* Update settings.json

* Updated rule

* Update .travis.yml

- run all

* Create DQC_0177.md

Added rule 177

* Update DQC_0177.xule

Added in rule identifier into 177

* Add documentation and message fix to rule 176

* Fixed typo in rule message

* Create DQC_0175.md

Added new rule form for 175

* Recompile v23 ruleset .zip files

* Update .travis.yml

- add dqc_0177 unit tests

* Update .travis.yml

---------

Co-authored-by: Campbell <campbell.pryde@xbrl.us>
davidtauriello and others added 29 commits February 21, 2024 11:24
* Updated rule 170 to exclude 20-F

* Added 10-Q to rule 170

* Updated date comparison

* Updated compiled

* Increment version and recompile ruleset .zip files

- Arelle 2.23.1 XULE 23722

---------

Co-authored-by: campbellpryde
Updated to 23.05
Updated to  use ' net of' for 2021
- v23.0.6
- Arelle 2.23.1 XULE 23722
- v23.0.6
- Arelle 2.23.1 XULE 23722
- recreate dqc_0015 non-neg log
* Updated rule 170 to exclude the 10-Q for flags

* Updated rule 004 to take into account tolerance of decimal values.

* Updated rule 60 to ignore quarterly data that is filed.

* Updated rule 167 to make the message clearer and easier to understand.

* Updated rule 126 not to run if calc includes LiabilitiesSubjectToCompromise

Excluded as Liabilities from notes may be included in this item in one year and not the prior year if the company goes into bankruptcy. Looks for the element ReorganizationUnderChapter11OfUSBankruptcyCodeDisclosureTextBlock exists and will skip if both conditions are present.

* Updated rule 123 to handle case for net assets per stock

* Fixed Typo in rule 43

* Merge for v23.0.6 Approved (#812)

* Updated rule 170 to exclude 20-F

* Added 10-Q to rule 170

* Updated date comparison

* Updated compiled

* Increment version and recompile ruleset .zip files

- Arelle 2.23.1 XULE 23722

* Update version.xule

Updated to 23.05

* Updated rule 154 to exclude labe with ' net of'

* Update DQC_0154.xule

Updated to  use ' net of' for 2021

* Updated for stock splits for rule 0009.15

* Fixed namespace for dtr-types

* Updated rule 170 to exclude the 10-Q for flags

* Update dqc_0015 for 2024 elements

* Update dqc_0015 for 2024 elements

* Update version and recompile

- v23.0.6
- Arelle 2.23.1 XULE 23722

* Update dqc_0015 test cases for 2024 UGT

* Update .travis.yml

* Update resources from CP xule.dqc

* Update dqc_0043

* Update copyright

* Recompile ruleset .zip files

- v23.0.6
- Arelle 2.23.1 XULE 23722

* Update .travis.yml

- recreate dqc_0015 non-neg log

* Rebuild dqc_0015 test case for UGT 2024

* Updated effective dates

* Update version and recompile ruleset.zip files

- v23.0.7
- Arelle 2.23.1 | XULE 23722

* Update v23 Approved rules effective date

- Amended to May 16, 2024 by DQC on March 14

* Update dqc_0167 unit tests for revised rule message

---------

Co-authored-by: campbellpryde <campbell.pryde@xbrl.us>
* Update markdown for typos

* Updated rule 170 to use the correct error message.

* Updated rule 0159 to handle special case.

* Update DQC_0159.xule

* Update version v23.0.8 and recompile ruleset .zip files

- Python 3.11.7 || Arelle 2.23.1 || XULE 23722

---------

Co-authored-by: campbellpryde
* Updated IFRS 176 to handle US GAAP elements

* Recompile ruleset .zip files

- Python 3.11.7 || Arelle 2.23.1 || XULE 23722

---------

Co-authored-by: campbellpryde
@davidtauriello davidtauriello merged commit 0d9ef78 into master Apr 10, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants