Skip to content

Commit

Permalink
Fix: Paging buttons would reduce to just 1 button if padding was appl…
Browse files Browse the repository at this point in the history
  • Loading branch information
AllanJard committed Mar 6, 2024
1 parent 0c18858 commit 24c79d2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/features/features.page.js
Expand Up @@ -104,7 +104,7 @@ function _pagingDraw(settings, host, opts) {
if (
buttonEls.length && // any buttons
opts.numbers > 1 && // prevent infinite
$(host).outerHeight() >= ($(buttonEls[0]).outerHeight() * 2) - 10
$(host).height() >= ($(buttonEls[0]).outerHeight() * 2) - 10

This comment has been minimized.

Copy link
@AllanJard

AllanJard Mar 6, 2024

Author Contributor

Yes - I want to check the overall height of the buttons inside the container. The height() for the wrapper is the inner part which is correct though.

I think this is correct and the test case appears to confirm that, but if you are having problems with it, I'd be happy to look at a test case.

) {
_pagingDraw(settings, host, $.extend({}, opts, { numbers: opts.numbers - 2 }));
}
Expand Down

0 comments on commit 24c79d2

Please sign in to comment.