New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for search, sorting, numbers, localization #264
Conversation
Thanks for this! I'll try to make some time later this week to review it :-) |
Highlevel points:
|
Thanks for your feedback. Sorry for replacing tabs with spaces, I noticed that only after committing the code. It has been fixed. You have a special category (feature) for a reason for such plug-ins among searching, ordering, etc. This means to me that these plugins could provide more than just searching, ordering. I think row grouping is necessary for this kind of feature (see https://news.google.com/newspapers, for example) Also you have some extensions conflicting with others, so it could be up to the user to decide which ones to use. So ordering is just another functionality provided by this feature plug-in, it sorts rows within its own row group. Regarding I really don't mean to introduce something that you don't want in the code base. If that is so, please don't hesitate to let me know. I will just host this code in a separate repository. |
Thanks for your reply. I appreciate your thoughts on this. I think, for the moment I would prefer that this plug-in remain just for filtering and additional options can be configured as people need. I won't take this PR as it is, but if I get a chance I'll bring in the i18n and numbers aspect, as I think those are really useful additions. |
I understand. I think I will create a separate repository to host this version of the plug-in retaining all the copyright and license of course. |
For the sake of reference, added a new repository at https://github.com/gyrocode/jquery-datatables-alphabetSearch |
Awesome - thanks! |
See demo at http://www.gyrocode.com/articles/jquery-datatables-alphabetical-search/