Skip to content

Commit

Permalink
Dev - fix: infoFiltered was not being applied due to a typo.
Browse files Browse the repository at this point in the history 
Fixes gh#96
  • Loading branch information
@AllanJard
AllanJard committed Nov 17, 2023
1 parent 9d9fba2 commit 73bc215
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions js/dataTables.scroller.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -854,8 +854,7 @@ $.extend(Scroller.prototype, {
}
else {
// Record set after filtering
result = language.sInfo;
' ' + language.sInfoFiltered + language.sInfoPostFix;
result = language.sInfo + ' ' + language.sInfoFiltered + language.sInfoPostFix;
}

result = this._macros(result, start, end, max, total);
Expand Down

6 comments on commit 73bc215

@BiomanRouge
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Allan,
When have you planned to publish this fix ?

Regards

@AllanJard
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm expecting the next release to drop in January. It is part of a large set of changes for DataTables 2.

@BiomanRouge
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for the info !

@BiomanRouge
Copy link

@BiomanRouge BiomanRouge commented on 73bc215 May 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Allan,
Could you please backport this fix to the 2.3 version (if it's possible) ?
We are still using DataTables v1.12 at the moment...

@AllanJard
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't currently plan to backport any bug fixes to support DataTables 1.x for old versions of Scroller (or the other extensions) I'm afraid. If there is a specific fix you need, such as this one though, you could readily download the JS file you are using and tweak it as needed.

@BiomanRouge
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for your reply.

Please sign in to comment.