Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed row height calculation for tables with only one row. #76

Closed
wants to merge 1 commit into from

Conversation

sh2ezo
Copy link

@sh2ezo sh2ezo commented Jun 28, 2018

If table has some dynamic content on row (in my case, it was a button, inserted inside 'render' event) and data has only one record, height of row calculates wrong way. Sorry for spaces instead of tabs. Saw your tabs on github after push.

@DataTables
Copy link
Collaborator

Are you able to give me a link to a page that shows the issue please? I'm not clear why adding one before and one after the current row would make a difference, since one of them is still going to be in the middle.

@sh2ezo
Copy link
Author

sh2ezo commented Jun 28, 2018

example:
http://jsfiddle.net/Lqpw4rbc/28/

As you can see, while table with only one row scales wrongly, table with two rows scales right way. This happens because in second table your code can measure row with inserted button, but in first table it can't. My fix adds the ability for measuring row in first case.

DataTables pushed a commit that referenced this pull request Aug 1, 2018
…here is only one row in the table.

Pull request #76 from sh2ezo. Thanks!
@DataTables
Copy link
Collaborator

I'm with you know! I've made a few changes to Scroller recently which causes a merge conflict, so I've just committed it directly. It will be available in the next release.

Allan

@sh2ezo sh2ezo closed this Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants