-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change from PS cmdlets to .NET commands for handling new lines and files #151
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I've got a couple more changes coming that should fix #150 I am running tests now! |
OK written tests around handling 429 and 404 web errors. It's good to go, pending review etc. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Confused as to how this fixes the 429 error I raised earlier...what changes have been made to the sleep timing? |
@RichieBzzzt reviewed the commits and see the parameterization as needed. I will now attempt to refactor my code to use it. Thank you for your prompt attention to this. |
PowerShell cmdlets have proven to cause issues across versions of PS and different OS and Git configs. Replace with .NET cmds seems to have removed issues of line formatting.
Have also removed the error where empty notebooks causes the threadjob to fail by checking
NewResponse
is not null.Have got the error message writing to console when one of the threadjobs have failed, which wasn't the case before.
Have updated the
Export-DatabricksFolder.tests.ps1
to write the output to where the notebooks were initially pushed from so that we can check if the content has been altered by any of the import/export commands.Added more notebooks with more lines for testing.
Should resolve -
#138
#140
Should undo damage caused by -
#139