Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from PS cmdlets to .NET commands for handling new lines and files #151

Merged
merged 5 commits into from
Oct 22, 2020
Merged

Conversation

RichieBzzzt
Copy link
Contributor

PowerShell cmdlets have proven to cause issues across versions of PS and different OS and Git configs. Replace with .NET cmds seems to have removed issues of line formatting.

Have also removed the error where empty notebooks causes the threadjob to fail by checking NewResponse is not null.

Have got the error message writing to console when one of the threadjobs have failed, which wasn't the case before.

Have updated the Export-DatabricksFolder.tests.ps1 to write the output to where the notebooks were initially pushed from so that we can check if the content has been altered by any of the import/export commands.

Added more notebooks with more lines for testing.
Should resolve -
#138

#140

Should undo damage caused by -

#139

@simondmorias
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@RichieBzzzt
Copy link
Contributor Author

I've got a couple more changes coming that should fix #150 I am running tests now!

@RichieBzzzt
Copy link
Contributor Author

OK written tests around handling 429 and 404 web errors. It's good to go, pending review etc.

@simondmorias
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryanbbrownavanade
Copy link

Confused as to how this fixes the 429 error I raised earlier...what changes have been made to the sleep timing?

@RichieBzzzt
Copy link
Contributor Author

Confused as to how this fixes the 429 error I raised earlier...what changes have been made to the sleep timing?

This check in should resolve it - bd0eeb4

added a retry if first attempt fails - 74b27d6

Admittedly the changes are lost in the check-ins and not properly commented.

@ryanbbrownavanade
Copy link

@RichieBzzzt reviewed the commits and see the parameterization as needed. I will now attempt to refactor my code to use it. Thank you for your prompt attention to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Good job - hacktoberfest!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants