fixes heights in Column embed layout

DataUSA · Mar 12, 2019 · c245ae9 · c245ae9
1 parent 0abae92
commit c245ae9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/app/components/Viz/index.jsx b/app/components/Viz/index.jsx
@@ -27,6 +27,7 @@ class Viz extends Component {
     }
     vizProps.config = Object.assign(vizProps.config, configOverride);
 
+    // Custom configuration for comparison profiles
     if (router.location.query.compare) {
       let {groupBy} = vizProps.config;
       if (!(groupBy instanceof Array)) groupBy = [groupBy];
@@ -37,6 +38,12 @@ class Viz extends Component {
       }
     }
 
+    // Custom configuration for embeds
+    const {sslug, tslug} = router.params;
+    if (sslug && tslug) {
+      if (vizProps.config.height) delete vizProps.config.height;
+    }
+
     // strip out the "type" from config
     const {type} = vizProps.config;
     delete vizProps.config.type;

diff --git a/app/profile/Embed.css b/app/profile/Embed.css
@@ -6,5 +6,13 @@
     & .d3plus {
       min-height: auto;
     }
+    &.Column {
+      & .topic-content {
+        flex: none;
+      }
+      & .topic-visualization {
+        flex: 1;
+      }
+    }
   }
 }