Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logo and source elements to PDFs and PNGs #352

Closed
pviechnicki opened this issue Apr 1, 2016 · 2 comments
Closed

add logo and source elements to PDFs and PNGs #352

pviechnicki opened this issue Apr 1, 2016 · 2 comments
Assignees
Labels

Comments

@pviechnicki
Copy link

On this profile, when I choose options->download->image, I get an image with black boxes instead of legend entries, plus there's no DataUSA logo. I thought the logo was supposed to appear on exports/embeds in this release. The legend export will need to be improved. You'll need to put colored and labeled boxes. The images with pop-ups won't work for the exports.

@davelandry
Copy link
Member

The issue with the legend is documented here: #262

The DataUSA logo does appear in embedded visualizations, as seen in this link. My understanding from the call where we discussed it was that we specifically didn't want the logo appearing in all file exports, but only on the web with a link back to the site.

@davelandry davelandry changed the title Image export not working for location profile, workforce treemap should the DataUSA logo appear on downloaded pngs/pdfs? Apr 1, 2016
@davelandry
Copy link
Member

I'm upgrading this from a question to a feature. We should include the data source and the site logo on all image/pdf downloads.

That being said, this is not an easy task, as the current rendering engine we use to generate the downloads only ingest the visualization itself. We will have to write custom code to also grab the source, along with rendering the logo on the fly (because it does not appear on the profile pages).

@davelandry davelandry changed the title should the DataUSA logo appear on downloaded pngs/pdfs? add logo and source elements to PDFs and PNGs Apr 8, 2016
@davelandry davelandry self-assigned this Apr 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants