Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests #14

Merged
merged 1 commit into from
Jan 5, 2015
Merged

Fix broken tests #14

merged 1 commit into from
Jan 5, 2015

Conversation

thiemowmde
Copy link
Contributor

Non-optional constructor arguments don't necessarily throw an Exception you can catch in a test, depending on the PHP/HHVM version/configuration they may cause a runtime error instead.

JeroenDeDauw added a commit that referenced this pull request Jan 5, 2015
@JeroenDeDauw JeroenDeDauw merged commit 3ce89f7 into master Jan 5, 2015
@JeroenDeDauw JeroenDeDauw deleted the nonOptional branch January 5, 2015 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants