Add TrimmingStringNormalizer

[thiemowmde]

Pinging @brightbyte.

This is a first step. It's possible to either add all regular expressions from \Wikibase\StringNormalizer to this class or to a new, similar class.

Bug: T47925

[brightbyte]

I'm confused why we would need this. We already have a StringNormalizer that does trimming and utf8 normalization. It lives in Wikibase.

We just need ValueView to actually start using it.

[thiemowmde]

You actually listed the reason why I did this: The normalizer we currently use does have an unwanted dependency on MediaWiki.

[JeroenDeDauw]

0.3.2

[Ladsgroup]

Do we still need this? Last update on it was two years ago!

[thiemowmde]

I still think this is a useful addition. We can at least use this in tests, and possibly simplify some of the more specific implementations in Wikibase that depend on MediaWiki.

[Ladsgroup]

Okay, So I assigned this to you and added the phab card to the sprint board to make sure this gets done (in less than two years hopefully) https://phabricator.wikimedia.org/T47925

[JeroenDeDauw]

Not a bugfix, so should increment the minor part of the version number as per http://semver.org/

[JeroenDeDauw]

Nvm my previous comment, I forgot this lib is stupidly still in the 0.x range.

a

[thiemowmde]

this lib is stupidly still in the 0.x range.

Do you realize you just called peoples decisions "stupid"?

[mariushoch]

What's up with this?

[thiemowmde]

I uploaded this 2015, trying to demonstrate the most simple, carefully designed alternative for parts of the badly designed \Wikibase\StringNormalizer utility class. I rebased this patch again now, but to be honest I'm tired of arguing why getting rid of \Wikibase\StringNormalizer and it's unnecessary MediaWiki dependency would be a good move.

[mariushoch]

Hm, it seems that StringNormalizer no longer depends on MediaWiki. Do you think it would make sense to move that?

[thiemowmde]

I still think a trivial trimming normalizer as proposed in this patch is helpful. But yea, the MediaWiki code used in Wikibase's StringNormalizer is now in a separate component called wikimedia/utfnormal. This means we actually can move it out of Wikibase now.