Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of the …::class feature #76

Merged
merged 1 commit into from Sep 29, 2017
Merged

Make use of the …::class feature #76

merged 1 commit into from Sep 29, 2017

Conversation

thiemowmde
Copy link
Contributor

No description provided.

@thiemowmde thiemowmde added this to the 1.0.0 milestone Sep 28, 2017
@thiemowmde thiemowmde changed the title Class feature Make use of the …::class feature Sep 28, 2017
@JeroenDeDauw
Copy link
Member

Thiemo, what I am seeing here is the following: First it becomes clear a certain change is controversial and then you introduce it alongside other changes in another PR without mentioning the change or the controversial bit. I am not sure how to interpret this as anything but anti-collaborative, and I feel this is disrespectful.

@thiemowmde
Copy link
Contributor Author

thiemowmde commented Sep 28, 2017

I believe you are referring to a mistake I made: I accidentally pushed two unrelated commits. I already fixed this like 30 seconds after I created the pull request. You might have seen the unrelated change in the email you got, but not here when you opened this page 5 minutes after I fixed the mistake already.

Please look more carefully at what you are blaming people for.

Besides, there is nothing "controversial" in #75. It's fixing a bug.

@JeroenDeDauw
Copy link
Member

Great to see it was a mistake. I've seen you do this in the past without amending it, hence I did not assume it was a mistake. Glad that we both can agree doing so on purpose would be uncool.

Besides, there is nothing "controversial" in #75. It's fixing a bug.

I'm objecting against it, so it is controversial. Or at the very least, I objected against it. That is what is important here, teamwork wise. Not the definition of a word.

@Ladsgroup Ladsgroup merged commit 608d7b6 into master Sep 29, 2017
@Ladsgroup Ladsgroup deleted the classFeature branch September 29, 2017 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants