Globe default value

[thiemowmde]

The $globe parameter of the constructor always had a default value, right? What I'm doing here is just reimplementing the exact same semantics in a slightly different way, right?

Before: new GlobeCoordinateValue( $latLang, $precision ) was possible but new GlobeCoordinateValue( $latLang, $precision, null ) failed. Doesn't make much sense if you think about, especially in terms of deserialization.

After: Both calls use the default value.

Bug: 66632

[JeroenDeDauw]

This will not fully fix bug 66632

[thiemowmde]

@JeroenDeDauw Can you explain? My impression was that it indeed solves the problem. It should replace NULL values in the database with the default value.

[JeroenDeDauw]

Values that could no longer be dezerlaized used to be turned into an UnDeserializableValue. We forgot to implement that in the new deserialization code. This PR does not address that issue, though it might itself be valid as well, I don't know.

[thiemowmde]

it might itself be valid as well

I think so. Earth is the default. I think there is no question about this. If NULL is stored (for whatever reason) why should it not fall back to the default?

[JeroenDeDauw]

To be clear: I have no objections against this commit and did not really review it. @filbertkm probably has an opinion on the actual change

[JeroenDeDauw]

Needs rebase

[brightbyte]

+1 looks fine. doesn't travis run here?...

[JeroenDeDauw]

Ok, I will then merge, and make sure the next rel is 0.3 (or 1.0)

[JeroenDeDauw]

@thiemowmde can you up the rel notes?

[thiemowmde]

Done. Fully agree to what @filbertkm said.