Fix precision handling in GlobeCoordinateFormatter and GeoCoordinateFormatter #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2014 14:01
Bug: 66653 Bug: 64820
Also fixes the GlobeCoordinateFormatter tests.
|
@jeroen: That depends on whether you believe that the old behaviour was actually well defined, or a bug. This changes the formatter to use the interpretation of "precision" to be the one used by the parser, fixing round trip compatibility. I'll leave it to you to decide whether this is a breaking change, or a fixing change... |
|
@brightbyte :) |
| @@ -101,6 +107,22 @@ public function __construct( FormatterOptions $options ) { | |||
| * @throws InvalidArgumentException | |||
| */ | |||
| public function format( $value ) { | |||
| $precision = $this->options->getOption( self::OPT_PRECISION ); | |||
| return $this->formatLatLongValue( $value, $precision ); | |||
There was a problem hiding this comment.
Fatal if not instanceof LatLongValue
|
The non-WB users of the lib that I know do not appear to be using OPT_PRECISION. So let's go with treating this as a fix then. |
JeroenDeDauw
added a commit
that referenced
this pull request
Oct 9, 2014
Fix precision handling in GlobeCoordinateFormatter and GeoCoordinateFormatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does two things:
It makes GlobeCoordinbateFormatter pas the precision stored in GlobeCoordinateValues to the GeoCoordinateFormatter, so the precision used is the one stored in the value, not the one defined by the options.
It changes the interpretation of "precision" used by the GeoCoordinateFormatter to be fractional degrees, as generated by the GlobeCoordinateParser and thus present in the database, instead of the previous interpretation "number of decimal digits".