Same exception handling for both DataValueDeserializer methods #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiemowmde
force-pushed
the
builderExceptions
branch
from
e6b1b14
to
098d899
Compare
thiemowmde
force-pushed
the
builderExceptions
branch
from
098d899
to
ff71f56
Compare
|
No test? |
|
Test is in #30 now. |
manicki
added a commit
that referenced
this pull request
Jun 23, 2017
Add missing test for change made in #29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvalidArgumentException should be turned into DeserializationException, and this should be done in both cases: with the old method that expected the DataValue class to have a
newFromArraymethod, and with the new method using callbacks.Bug: T168681