Fixes Bug 62730 #10
Merged
Fixes Bug 62730 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://bugzilla.wikimedia.org/show_bug.cgi?id=62730 Before this change if 2012-02-00 was passed in with precision of a DAY as an opt the TimeValue would have the precision of a DAY. Now instead this will fall back to the precision of a MONTH
|
|
||
| * Removed TimeParser::SIGN_PATTERN constant | ||
| * Removed TimeParser::TIME_PATTERN constant | ||
| * Fix [bug 62730](https://bugzilla.wikimedia.org/show_bug.cgi?id=62730) TimeParser should return correct precision when only month and year or year is given |
There was a problem hiding this comment.
Bad grammar for the last point.
Fixed [bug 62730](https://bugzilla.wikimedia.org/show_bug.cgi?id=62730). The TimeParser now returns the correct precision when only month and year or year is given
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.wikimedia.org/show_bug.cgi?id=62730