Parse and refuse invalid calendar option #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
thiemowmde
force-pushed
the
calendarOption
branch
from
c65571c
to
81d5a46
Compare
thiemowmde
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do classify this as a bug. An unknown calendar string should either be kept as it is (TimeValue happily stores any non-empty string, and the validators we have in place will reject everything that's not a Wikidata concept URI). Or it should be rejected if the relevant CalendarModelParser does not understand it (which is what this patch does). But unknown strings should never silently become the Gregorian URI.
You might think this is a breaking change because code that could never fail before now throws a ParseException. But note this was always possible and documented, see IsoTimestampParser::stringParse. The exception is just thrown for one more reason now.
Bug: T141518