Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix :mongo adapter to clean up newly created collection #6

Merged
merged 1 commit into from
May 16, 2020

Conversation

mtsmfm
Copy link
Contributor

@mtsmfm mtsmfm commented May 16, 2020

@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #6 into master will increase coverage by 4.85%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master        #6      +/-   ##
===========================================
+ Coverage   95.14%   100.00%   +4.85%     
===========================================
  Files           6         6              
  Lines         103        91      -12     
===========================================
- Hits           98        91       -7     
+ Misses          5         0       -5     
Impacted Files Coverage Δ
lib/database_cleaner/mongo/truncation.rb 100.00% <100.00%> (+12.50%) ⬆️
spec/database_cleaner/mongo/truncation_spec.rb 100.00% <100.00%> (ø)
spec/support/database_helper.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b39e7d9...0573b1b. Read the comment docs.

Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtsmfm Thanks for submitting this PR! It looks good to me, but I don't know enough about this adapter to approve it.

@botandrose could you review it as well? thanks!

@botandrose botandrose merged commit 97514c2 into DatabaseCleaner:master May 16, 2020
@botandrose
Copy link
Contributor

@mtsmfm Thank you for this PR, and your work on the mongo adapter in general. With this, I think it its ready for v2.0!

@etagwerker This one was pretty interesting. Turns out the mongo adapter has been basically unusable for eight years! See original PR for more context: DatabaseCleaner/database_cleaner#646

@mtsmfm mtsmfm deleted the dont-cache-collection branch May 16, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants