Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Rename truncation strategy to deletion. #7

Merged
merged 1 commit into from
May 30, 2020
Merged

Conversation

botandrose
Copy link
Contributor

@botandrose botandrose commented May 17, 2020

MongoDB doesn't have a truncate command, and the MongoDB command actually being invoked here on the database is named deleteMany, so I think this makes sense.

Will need to add deprecation warnings to 1.99 for this transition.

Also, I fixed up the configuration docs in the README while I was at it.

@codecov
Copy link

codecov bot commented May 17, 2020

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           96        89    -7     
=========================================
- Hits            96        89    -7     
Impacted Files Coverage Δ
lib/database_cleaner/mongo.rb 100.00% <100.00%> (ø)
lib/database_cleaner/mongo/deletion.rb 100.00% <100.00%> (ø)
spec/database_cleaner/mongo/deletion_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 435f09c...63ee64a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants