Fix for Sequel 3.34.1 #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change in 3.34: "Database#uri and url now return the connection string given to Sequel.connect. Previously, they tried to reconstruct the url using the database's options, but that didn't work well in corner cases." Lo and behold there's a database_type() method anyway and it was there in 3.33 all along.
This was referenced Jun 3, 2012
|
I'll be merging in a fix soon.. see discussion on #120, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for change in Sequel 3.34:
"Database#uri and url now return the connection string given to
Sequel.connect. Previously, they tried to reconstruct the url using the
database's options, but that didn't work well in corner cases."