Support regular expressions in allowlist #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 651 666 +15
=========================================
+ Hits 651 666 +15
Continue to review full report at Codecov.
|
|
@bpo Thanks for the PR! I really like this change, and with the switch to One last thing before I sign off on it: would you please add a changelog entry? @etagwerker This looks good to me. What do you think? |
|
👍 added changelog, and another example using a |
etagwerker
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common for database connection parameters to be specified as part of the URL (e.g.
DATABASE_URL=postgres://foo.bar?pool=16). I'd like to be able to manipulate those connection parameters in my test rig without needing to alter the allowlist.This patch supports this by letting allowlists optionally be specified as regular expressions.