Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart Title Localization #9

Merged
merged 6 commits into from Feb 24, 2022
Merged

Chart Title Localization #9

merged 6 commits into from Feb 24, 2022

Conversation

greenrhyno
Copy link
Contributor

Adds localization logic into the chart title generation function so that charts can be more fully translated.

Changes include:

  • edited Translation type to include new keys
  • added default sentence fragments for default english locale
  • updated README to account for changes to the Translation interface

@greenrhyno greenrhyno added enhancement New feature or request help wanted Extra attention is needed labels Feb 23, 2022
@greenrhyno greenrhyno self-assigned this Feb 23, 2022
@greenrhyno
Copy link
Contributor Author

@frabarz -- Do you think we should include a Spanish translation by default in the code?

@frabarz
Copy link
Collaborator

frabarz commented Feb 23, 2022

Nah, that'd ship with the package in all bundles, even if Spanish is not intended for use. The English default is enough to have a basis for the user to work with.

Copy link
Contributor Author

@greenrhyno greenrhyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes requested by Dave. Looks good to go.

@greenrhyno greenrhyno merged commit e4b673f into master Feb 24, 2022
@greenrhyno greenrhyno deleted the title-translation branch February 24, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants