New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart Title Localization #9
Conversation
@frabarz -- Do you think we should include a Spanish translation by default in the code? |
Nah, that'd ship with the package in all bundles, even if Spanish is not intended for use. The English default is enough to have a basis for the user to work with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the changes requested by Dave. Looks good to go.
…brace interpolation
Adds localization logic into the chart title generation function so that charts can be more fully translated.
Changes include:
Translation
type to include new keysTranslation
interface