Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make value_ptr const #49

Merged
merged 2 commits into from Mar 22, 2015
Merged

make value_ptr const #49

merged 2 commits into from Mar 22, 2015

Conversation

extrawurst
Copy link
Contributor

this still works with the gl methods taking const GLfloat*

this still works with the gl methods taking const GLfloat*
@Dav1dde
Copy link
Owner

Dav1dde commented Mar 21, 2015

Looks good to me, can you do the same for Quaternions and Vectors as well?

@extrawurst
Copy link
Contributor Author

ok done, good to go ?

Dav1dde added a commit that referenced this pull request Mar 22, 2015
@Dav1dde Dav1dde merged commit ed1a2c4 into Dav1dde:master Mar 22, 2015
@Dav1dde
Copy link
Owner

Dav1dde commented Mar 22, 2015

Thanks

@mathstuf
Copy link
Contributor

I'm getting unresolved symbols with this patch. The demangled symbol looks weird:

const(pure nothrow @property @safe const(float)* function()) gl3n.linalg.Matrix!(float, 4, 4).Matrix.value_ptr

@mathstuf
Copy link
Contributor

Using gdc 2.065.

@Dav1dde
Copy link
Owner

Dav1dde commented Mar 25, 2015

Any ideas why this happens and how this is fixable? @extrawurst

@extrawurst
Copy link
Contributor Author

@mathstuf sure you have rebuilt the lib after upgrading ?

@extrawurst extrawurst deleted the patch-1 branch March 25, 2015 10:13
@extrawurst
Copy link
Contributor Author

i cannot reproduce the issue on win32 using dmd2.065. @Dav1dde maybe a travis-ci integration can prevent those issues in the future? it is easy to integrate to even test multiple compiler flavours and its free ;)

@extrawurst extrawurst mentioned this pull request Mar 25, 2015
@mathstuf
Copy link
Contributor

Yep, started with a clean build too.

@extrawurst
Copy link
Contributor Author

@mathstuf as you can see travis-ci tests those compilers too now. gdc works too

@mathstuf
Copy link
Contributor

I guess to be clear, this is in a project using this gl3n build.

@extrawurst
Copy link
Contributor Author

so ? travis-ci builds for unittesting which is pretty much the same and i am using gl3n in a project that is built using travis with gdc: https://github.com/Extrawurst/unecht

@mathstuf
Copy link
Contributor

So what would cause that weird signature? It looks like it's returning a constant pointer to a function returning a const(float)*.

@Dav1dde
Copy link
Owner

Dav1dde commented Mar 26, 2015

Is it possible for you to provide a minimal example? Did you try with dmd instead of gdc?

@mathstuf
Copy link
Contributor

mathstuf commented Apr 2, 2015

Oops, my bad. Seems the library I was using was pointing to the wrong build tree. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants