Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed memory leaks. Second example with texture added. #9

Merged
merged 1 commit into from
Sep 12, 2013
Merged

Fixed memory leaks. Second example with texture added. #9

merged 1 commit into from
Sep 12, 2013

Conversation

drug007
Copy link
Contributor

@drug007 drug007 commented Sep 10, 2013

Second example with texture added.
Memory leaks fixed - in stb and DevIL(default) version loading a texture from file causes memory leaks because allocated while loading memory not be freed.

@Dav1dde
Copy link
Owner

Dav1dde commented Sep 11, 2013

Thanks, I noted a few minor style things, would be great if you could fix them. Also why do you have a trailing slash on "texture", "vbo" etc. in the example, that doesn't follow glamour either? If you're done squash the commits into one (in case you don't know how to):

git commit -am "fixed last few style issues"
git rebase -i HEAD~2
# editor opens, replace the last pick with fixup, save the document
git push -f origin master
# Pull request will update automatically

In stb and DevIL(default) version loading a texture from file causes memory leaks because allocated while loading memory not be freed.
@drug007
Copy link
Contributor Author

drug007 commented Sep 11, 2013

The examples are part of my code, trailing slash using is my code style and it's simpler for me to just copy part of my code than do renaming additionally. But of course if them should be avoided, I'll removed slashes.

@Dav1dde
Copy link
Owner

Dav1dde commented Sep 12, 2013

Awesome, looks great. Can't test it right now but I trust you ;).

Dav1dde added a commit that referenced this pull request Sep 12, 2013
Fixed memory leaks. Second example with texture added.
@Dav1dde Dav1dde merged commit e19ab0a into Dav1dde:master Sep 12, 2013
@drug007
Copy link
Contributor Author

drug007 commented Sep 12, 2013

Thank you. :) But it would be better to test it, because I've tested only SDLImage version. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants