add section: File resolution (#434) #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavHau
reviewed
Apr 25, 2022
Readme.md
Outdated
Comment on lines
222
to
260
| The wheel URL is constructed in [pypi-crawlers/src/crawl_wheel_deps.py](pypi-crawlers/src/crawl_wheel_deps.py) | ||
|
|
||
| ```py | ||
| def construct_url(name, pyver, filename: str): | ||
| base_url = "https://files.pythonhosted.org/packages/" | ||
| return f"{base_url}{pyver}/{name[0]}/{name}/{filename}" | ||
| ``` | ||
|
|
||
| So in this example, the full URL would be | ||
|
|
||
| ``` | ||
| https://files.pythonhosted.org/packages/cp39/p/pillow/Pillow-9.1.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl | ||
| ``` | ||
|
|
||
| Now we can call Nix's `fetchurl` like | ||
|
|
||
| ```nix | ||
| builtins.fetchurl { | ||
| url = "https://files.pythonhosted.org/packages/cp39/p/pillow/Pillow-9.1.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl"; | ||
| sha256 = "gig6+ZwcOluh2kTGcpbVqtGfEcU1tVGlrlUyijF84zE="; | ||
| } | ||
| ``` | ||
|
|
||
| ... and we get | ||
|
|
||
| ``` | ||
| $ unzip -l /nix/store/7gbbbrsqkw7f69axyh818abh9yw45fnb-Pillow-9.1.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl | head | ||
| Archive: /nix/store/7gbbbrsqkw7f69axyh818abh9yw45fnb-Pillow-9.1.0-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl | ||
| Length Date Time Name | ||
| --------- ---------- ----- ---- | ||
| 0 04-01-2022 10:08 PIL/ | ||
| 0 04-01-2022 10:08 Pillow.libs/ | ||
| 0 04-01-2022 10:08 Pillow-9.1.0.dist-info/ | ||
| 7311 04-01-2022 10:08 PIL/PdfImagePlugin.py | ||
| 141328 04-01-2022 10:08 PIL/_imagingcms.cpython-39-x86_64-linux-gnu.so | ||
| 46872 04-01-2022 10:08 PIL/_imagingtk.cpython-39-x86_64-linux-gnu.so | ||
| 1513 04-01-2022 10:08 PIL/GribStubImagePlugin.py | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Is this really relevant to the user?
Should this better go to a contributors guide?
There was a problem hiding this comment.
yes ... lets move the whole how-does-mach-nix-work section to implementation.md?
There was a problem hiding this comment.
lets move the whole
how-does-mach-nix-worksection toimplementation.md?
probably no
a "high level view" should stay in readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #434
maybe a bit too verbose ...
maybe belongs to
eli5.md; )