Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow a linked NP_LOCATION #76

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Follow a linked NP_LOCATION #76

merged 1 commit into from
Dec 7, 2023

Conversation

erooke
Copy link
Contributor

@erooke erooke commented Nov 17, 2023

Aims to fix #75.

If $NP_LOCATION is linked to a location broot will fail to start. This dereferences any link in $NP_LOCATION. I have not tested it beyond confirming that it works on my local machine and my HPC cluster.

@CamoCatX
Copy link

CamoCatX commented Dec 1, 2023

Do you know why it fails on Debian and Ubuntu? It seems like the error for the Debian is the build tools are the wrong platform. Looking at other pull requests, it seems this common. Is your HPC (High Performance Computing) cluster on AARCH64?

@erooke
Copy link
Contributor Author

erooke commented Dec 5, 2023

Do you know why it fails on Debian and Ubuntu?

The Ubuntu error has to do with it failing to download the qemu image which I reckon is what #80 is solving. The Debian error is more confusing to me, as you said it looks to be a cross compiling issue (failing to build for arm on x86) but I'm not sure what about my change would have broken that.

Is your HPC (High Performance Computing) cluster on AARCH64?

Nah, it's x86_64.

@DavHau
Copy link
Owner

DavHau commented Dec 6, 2023

the aarch64 vm tests run on x86 host with qemu emulation. It should not need to build anything for aarch64, but somehow it does.
I'll just add binfmt to the vm tests as well: 1fa859a

@DavHau
Copy link
Owner

DavHau commented Dec 6, 2023

That thing is merged now. Could you rebase and see if the pipeline passes now?

If `$NP_LOCATION` is linked to a location broot will fail to start. This
dereferences any link in `$NP_LOCATION`.
@DavHau
Copy link
Owner

DavHau commented Dec 7, 2023

Whatever, I'll have to debug the pipeline more. This commit is for sure not the reason it breaks

@DavHau DavHau merged commit cb0beb5 into DavHau:master Dec 7, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nix-portable breaks on symlinked home directory
3 participants