Skip to content

Commit

Permalink
hdf5: Revert to normal linker
Browse files Browse the repository at this point in the history
.

Revert workaround for Sonoma/Xcode 15.0.
`ld_classic` is no longer needed with HDF5 1.14.3.
HDFGroup/hdf5#3571
HDFGroup/hdf5#3581
"Removed "-commons" linking option on Darwin"
https://github.com/HDFGroup/hdf5/blob/hdf5_1_14_3/release_docs/RELEASE.txt
  • Loading branch information
Dave-Allured committed Nov 12, 2023
1 parent 7720d55 commit 8266761
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions science/hdf5/Portfile
Original file line number Diff line number Diff line change
Expand Up @@ -72,16 +72,6 @@ configure.args \
--with-szlib=${prefix}/lib/libaec \
--with-zlib=yes

if { [vercmp ${xcodeversion} >= 15.0] || [vercmp ${xcodecltversion} >= 15.0] } {
# On macOS13 and newer ensure the 'legacy' linker is used as GCC currently has problems
# with the new default linker in Xcode 15. See e.g.
# https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking
# https://discussions.apple.com/thread/255137447
# https://developer.apple.com/forums/thread/737707
# https://github.com/Homebrew/homebrew-core/issues/145991
configure.env LDFLAGS=-ld_classic
}

# Actively checks how to get clang to warn on implicit functions with this.
configure.checks.implicit_function_declaration.whitelist-append strchr

Expand Down

0 comments on commit 8266761

Please sign in to comment.