Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 8.2 deprecations #56

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix PHP 8.2 deprecations #56

wants to merge 4 commits into from

Conversation

mdio
Copy link

@mdio mdio commented Nov 10, 2023

Several things happened here in order to support current PHP versions:

  • Upgrade PHPUnit to 9 + fix test signature and bcmath errors with passing strings like "two"
  • Replace utf8_decode with mb_convert_encoding (as it's deprecated in PHP 8.2)
  • I then removed the code that was running when ext-mbstring wasn't available as it's a requirement now anyway.

@mdio
Fix tests to run with PHP 8.0/PHPUnit 9
1e6028f
@mdio
Replace utf8_decode with mb_convert_encoding
4ba1393 
utf8_decode is deprecated in PHP 8.2.
ext-mbstring is now a requirement.
@mdio
Remove $blnMbstring and related code
0fa069c 
Because ext-mbstring is required now anyway.
@mdio
Fix version constraint for ext-mbstring
1892c3b
Radcliffe pushed a commit to Radcliffe/Text-Statistics that referenced this pull request Dec 18, 2023
@dgradcliffe
apply patches for PR DaveChild#55 and DaveChild#56
0ce6254
pattonwebz added a commit to equalizedigital/textstatistics that referenced this pull request Apr 2, 2024
@pattonwebz
Apply patch from DaveChild#56
df72902
@seanBlommaert seanBlommaert mentioned this pull request Jul 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mdio