Enable compatibility with Linux (and other) kernel #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace sprintf() usage with the safer snprintf(). Since snprintf() was introduced only in C99, we have to upgrade the minimum C standard. Signed-off-by: Andrey Gelman <andrey.gelman@gmail.com>
Introduce a rigorous FP value parsing function, that identifies precisely the number of bytes that can be skipped in the input. After this, we can afford to drop strtod() in favor of a more robust sscanf(). Signed-off-by: Andrey Gelman <andrey.gelman@gmail.com>
Enable building without FP support (cmake -DNO_FLOATING_POINT=TRUE ...) This is required as a part of the effort to make cJSON available in the kernel mode. Notice, since the tests rely on FP availability, we had to disable tests in case of NO_FLOATING_POINT. TODO: Introduce new tests / adapt existing tests Signed-off-by: Andrey Gelman <andrey.gelman@gmail.com>
Adapt cJSON library to serving as a part of a Linux kernel driver: - copy cJSON.[ch] to the driver source code tree - integrate in the build process Signed-off-by: Andrey Gelman <andrey.gelman@gmail.com>
|
As it's declared in README: cJSON is designed to use |
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jun 6, 2024
* Rework Makefile to follow Porters Handbook more closely * Fix issues reported by DEVELOPER=yes * Adjust CMAKE args to be readable and there's no need to list every possible option * Compile to c89 standard as other distros and upstream [1] * Drop static libs, nothing in tree uses them 1: https://github.com/DaveGamble/cJSON/blob/v1.7.18/CMakeLists.txt#L22 DaveGamble/cJSON#836 PR: 279133 Approved by: portmgr (maintainer timeout, 2+ weeks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to enable using cJSON in the kernel space, in particular Linux kernel.
This requirement has 3 consequences:
When building as a part of Linux kernel code, the KERNEL macro will be recognized automatically.
In order to build with no floating point numbers, introduce NO_FLOATING_POINT macro. This macro is automatically introduced in case KERNEL is present.
This PR strives to keep all the existing functionality unchanged.