Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE ProjectRoot to use named constructors, one for from CWD and other for when Project Root is specified #88

Merged
merged 2 commits into from
May 23, 2021

Conversation

DaveLiddament
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2021

Codecov Report

Merging #88 (1fea215) into master (129e3cf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #88   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       482       484    +2     
===========================================
  Files            104       104           
  Lines           1493      1500    +7     
===========================================
+ Hits            1493      1500    +7     
Impacted Files Coverage Δ Complexity Δ
src/Domain/Common/ProjectRoot.php 100.00% <100.00%> (ø) 8.00 <4.00> (+2.00)
...c/Framework/Command/internal/ProjectRootHelper.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 129e3cf...1fea215. Read the comment docs.

@DaveLiddament DaveLiddament merged commit 0150e03 into master May 23, 2021
@DaveLiddament DaveLiddament deleted the refactor/project-root-change branch May 23, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants