Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SMI default values #1081

Merged
merged 6 commits into from Sep 24, 2023
Merged

add SMI default values #1081

merged 6 commits into from Sep 24, 2023

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Aug 31, 2023

Adds SMI default values, according to related facioquo/stock-charts#269

Done when:

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have put comments in my code, particularly for hard-to-understand areas
  • I have performed a self-review of my code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings or other code analysis issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
Signed-off-by: Dave Skender <8432125+DaveSkender@users.noreply.github.com>
@DaveSkender DaveSkender marked this pull request as ready for review September 24, 2023 22:27
@DaveSkender DaveSkender enabled auto-merge (squash) September 24, 2023 22:28
@DaveSkender DaveSkender merged commit 737f536 into main Sep 24, 2023
4 checks passed
@DaveSkender DaveSkender deleted the smi-defaults branch September 24, 2023 22:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant